-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(tables): fix bulk ops truncation for tables larger than one page #4532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c36f80c
fix(tables): fix bulk ops truncation for tables larger than one page
waleedlatif1 9099a98
chore(tables): remove extraneous comments
waleedlatif1 61752e9
fix(tables): add missing useEffect import; chunk range-selection dele…
waleedlatif1 2cb026d
fix(tables): add hasRunningGroupExecution and import it
waleedlatif1 a4e7db2
fix(tables): define mergePagePreservingIdentity helper used in pollin…
waleedlatif1 46e3bbf
fix(tables): define ROWS_POLL_INTERVAL_WHILE_RUNNING_MS constant used…
waleedlatif1 6f93d34
fix(tables): capture rowSel before await in delete handler; handle cl…
waleedlatif1 8342607
fix(tables): abort cut on clipboard NotAllowedError to prevent silent…
waleedlatif1 691746d
fix(tables): push undo before chunkBatchUpdates to survive partial ch…
waleedlatif1 fa77b7f
fix(tables): use text input for number cells; idle poll backoff; csv …
waleedlatif1 4c63d4f
fix(tables): audit fixes — column-copy drain, polling scope, merge id…
waleedlatif1 783d397
improvement(tables): cleanup — extract components, stabilize callback…
waleedlatif1 e3626f1
improvement(tables): remove polling, eager drain, and parallelize bat…
waleedlatif1 e8b3c95
chore(tables): remove stale comments and dead defensive code
waleedlatif1 3f0da17
fix(tables): run-all selection sends all rows to server, not just loa…
waleedlatif1 bf98e8c
test(tables): remove background-drain describe block (behavior intent…
waleedlatif1 e3f2da4
fix(tables): surface CSV import error toast; remove dead hasRunningGr…
waleedlatif1 e7b5a01
fix(tables): make runWithoutRecording async-aware so undoRedoInProgre…
waleedlatif1 685ae54
feat(tables): render URL cells with favicon and clickable link
waleedlatif1 290b4bf
feat(tables): clickable URL cells with favicons using tldts
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.