fix: handle webhook errors without toJSON#579
Open
saschabuehrle wants to merge 1 commit intoslackapi:mainfrom
Open
fix: handle webhook errors without toJSON#579saschabuehrle wants to merge 1 commit intoslackapi:mainfrom
saschabuehrle wants to merge 1 commit intoslackapi:mainfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @saschabuehrle to sign the Salesforce Inc. Contributor License Agreement. |
Member
|
👋 Hey @saschabuehrle! Thanks so much for taking the time to send this in! Before reviewing the changes, can I ask you to sign the CLA linked above? It's required as part of our contribution process 🏛️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #511
Webhook.post currently assumes every thrown error implements toJSON(). That crashes error handling itself for non-Axios errors (for example invalid webhook input), hiding the original cause.
This change adds a safe fallback when toJSON is not available, preserves status/message outputs, and throws SlackError with a cause so the root error is still available.
Also adds a regression test for a non-Axios TypeError path.
Greetings, saschabuehrle