Add support for the Cadence SD6 SDHCI controller#581
Open
renjithkumarnair wants to merge 1 commit into
Open
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
paulmenzel
suggested changes
May 26, 2026
Contributor
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Please send the patch upstream for review (the tool b4 helps, or normal git commands git format-patch … and git send-email …).
| @@ -0,0 +1,2902 @@ | |||
| From d1910de6f9c5de27eecf89dc12a165a600aac833 Mon Sep 17 00:00:00 2001 | |||
| From: rnair <rnair@marvell.com> | |||
Contributor
There was a problem hiding this comment.
Please use your full name.
| struct nix_lf_alloc_rsp with hw_rx_tstamp_en to match the mbox | ||
| structure with applications. | ||
|
|
||
| Signed-off-by: rnair <rnair@marvell.com> |
renjithkumarnair
force-pushed
the
sonic_octeon_202605
branch
from
20e778f to
bcf1eb2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
renjithkumarnair
force-pushed
the
sonic_octeon_202605
branch
from
bcf1eb2 to
033399b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
renjithkumarnair
force-pushed
the
sonic_octeon_202605
branch
from
033399b to
66f48dd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
renjithkumarnair
left a comment
renjithkumarnair
left a comment
There was a problem hiding this comment.
Review comments incorporated.
renjithkumarnair
force-pushed
the
sonic_octeon_202605
branch
from
66f48dd to
980a5ef
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
----------- Added support for Cadence Sdhci eMMC controller for octeon platform This includes enabling the Cadence SD6 controller, HS400/HS400ES modes, ACPI integration, PHY delay tuning, and multiple fixes for timing, tuning, and controller corner cases. Also updated the OTX2 mailbox interface version and related structures. Why I did it ------------ Octeon platforms require specific controller handling and tuning for reliable high-speed eMMC operation. Existing driver support lacked MMC Controller-specific configurations, resulting in instability and incorrect operation in HS400-class modes. Additionally, mailbox structure updates were needed to align kernel and application interfaces How I verified it ----------------- - Booted Octeon platform with updated driver - Verified eMMC enumeration and initialization - Tested HS400 / HS400ES mode transitions - Validated tuning execution and value population - Verified mailbox compatibility with updated structure Details if related ------------------ - Added Cadence SD6 SDHCI controller support - Enabled HS400 and HS400ES modes - Configured PHY delays and default tuning values when DT values are missing or invalid - Implemented delay element handling and Cadence-specific tuning logic, including multi-block read helpers - Improved handling of DDR, clocking, enhanced strobe, command delay, block gap, and interrupt corner cases - Added ACPI support for Octeon Cadence SDHCI instance - Updated OTX2_MBOX_VERSION to 0x000b - Extended struct nix_lf_alloc_rsp with hw_rx_tstamp_en Patch upstreaming plan ---------------------- - These patches are not to be upstreamed. - There are parallel threads in Progress to give sd6hc support, which needs to be evaluated first: https://lkml.org/lkml/2026/5/11/2580 Signed-off-by: Renjithkumar Raveendran Nair <renjithkumar@gmail.com>
renjithkumarnair
force-pushed
the
sonic_octeon_202605
branch
from
980a5ef to
809e075
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
renjithkumarnair
commented
Jun 3, 2026
Author
renjithkumarnair
left a comment
renjithkumarnair
left a comment
There was a problem hiding this comment.
The CLA has been signed now.
Author
This patch is not to be upstreamed as it is. There is another Code change coming towards adding SD6 support by other party (which can overlap/clash over this) in progress in the linux-mmc forum. So basically, have to wait for that patch to reflect in upstream and only patch up this driver upon that as needed; else it would clash. |
renjithkumarnair
commented
Jun 5, 2026
Author
renjithkumarnair
left a comment
renjithkumarnair
left a comment
There was a problem hiding this comment.
Upstream task will be delayed - Given justification.
|
@lizhijianrd @Blueve please help in getting this PR reviewed. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added support for Cadence Sdhci eMMC controller for octeon platform.
This includes enabling the Cadence SD6 controller, HS400/HS400ES modes,
ACPI integration, PHY delay tuning, and multiple fixes for timing,
tuning, and controller corner cases.
Also updated the OTX2 mailbox interface version and related structures.
Why I did it
Octeon platforms require specific controller handling and tuning for reliable
high-speed eMMC operation. Existing driver support lacked MMC
Controller-specific configurations, resulting in instability and incorrect
operation in HS400-class modes. Additionally, mailbox structure updates
were needed to align kernel and application interfaces
How I verified it
Details if related
Patch upstreaming plan