bug: only require CI=true and AccessToken when making API requests#1278
Merged
bug: only require CI=true and AccessToken when making API requests#1278
Conversation
keegancsmith
approved these changes
Mar 25, 2026
- rename `RequireAccessToken` to `checkIfCIAccessTokenRequired` - provide more context in error on why it happened
burmudar
force-pushed
the
wb/bug-src-token-and-ci
branch
from
e6c2532 to
cd32acb
Compare
devdinu
approved these changes
Mar 25, 2026
burmudar
added a commit
that referenced
this pull request
Mar 26, 2026
…1278) * check when inCI and whether we required Access Token * fast fail in APIClient when CI=true and no Access Token * use apiClient constructor in search_jobs * fail fast in login / auth token when CI=true and AccessToken not set * add comment * review feedback - rename `RequireAccessToken` to `checkIfCIAccessTokenRequired` - provide more context in error on why it happened * use sentinel error * use lib errors (cherry picked from commit 0e5e006)
burmudar
added a commit
that referenced
this pull request
Mar 26, 2026
…1278) * check when inCI and whether we required Access Token * fast fail in APIClient when CI=true and no Access Token * use apiClient constructor in search_jobs * fail fast in login / auth token when CI=true and AccessToken not set * add comment * review feedback - rename `RequireAccessToken` to `checkIfCIAccessTokenRequired` - provide more context in error on why it happened * use sentinel error * use lib errors (cherry picked from commit 0e5e006)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/sourcegraph/sourcegraph/actions/runs/23518169374/job/68455311352?pr=11118 the action failed on command
src version -client-only, where it should not have failed because it's a client only check and no API interaction thus not requiring a Access Token to be set.In this PR we update the config:
Update APIClient:
Closes CPL-291
Test plan
unit tests + manual tests