Skip to content

SPL-298478: Add App CRD on M1 milestone branch#1826

Open
jzywiecki wants to merge 4 commits intomvp/app-framework-v1from
mvp/app-framework-v1-app-crd
Open

SPL-298478: Add App CRD on M1 milestone branch#1826
jzywiecki wants to merge 4 commits intomvp/app-framework-v1from
mvp/app-framework-v1-app-crd

Conversation

@jzywiecki
Copy link
Copy Markdown

@jzywiecki jzywiecki commented Apr 8, 2026

Description

This PR adds the new App custom resource definition to the operator.

Key Changes

  • Added the new App API type under enterprise.splunk.com/v4
  • Generated and registered the App CRD
  • Added a sample App manifest and wired it into sample kustomization
  • Regenerated deepcopy and CRD artifacts to reflect the final schema

Testing and Verification

  • Regenerated manifests and deepcopy code with make manifests generate
  • Verified the API changes
  • Checked the generated CRD schema for the new spec and status fields
  • Manual testing of creating the CR

Fields that must be set validation:

appID: Unique identifier of the application

image

version: Desired application version

image

targetRef:

image

kind

image

name

image

sourceRef: Reference to an AppSource resource

image

package:

image

path: Path to the application package within the source

image

scope: Deployment scope definition

image

Related Issues

  • SPL-298478

Screenshots

Pasted Graphic 1 image

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@jzywiecki jzywiecki requested a review from naimulh247 April 8, 2026 12:58
@naimulh247
Copy link
Copy Markdown

There are some merge conflicts, can we rebase and push again

Copy link
Copy Markdown

@naimulh247 naimulh247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to consider using pointers as part of the app_types.go to know if user defined the field or not

@jzywiecki jzywiecki force-pushed the mvp/app-framework-v1-app-crd branch from bffa2f9 to 86350ea Compare April 10, 2026 13:32
Copy link
Copy Markdown
Collaborator

@vivekr-splunk vivekr-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two blocking issues in the current App CRD/controller shape.

@jzywiecki jzywiecki force-pushed the mvp/app-framework-v1-app-crd branch from 99d10eb to f5518fe Compare April 10, 2026 15:17
@jzywiecki jzywiecki changed the title feat: Add App CRD on MVP branch feat: Add App CRD on M1 milestone branch Apr 15, 2026
@jzywiecki jzywiecki changed the title feat: Add App CRD on M1 milestone branch SPL-298478: Add App CRD on M1 milestone branch Apr 15, 2026
@jzywiecki jzywiecki force-pushed the mvp/app-framework-v1-app-crd branch from b80ace9 to 43688f2 Compare April 15, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants