Skip to content

feat: support setting clientAuthenticationMethod for OIDC#765

Open
dervoeti wants to merge 1 commit intomainfrom
feat/oidc-client-auth-method
Open

feat: support setting clientAuthenticationMethod for OIDC#765
dervoeti wants to merge 1 commit intomainfrom
feat/oidc-client-auth-method

Conversation

@dervoeti
Copy link
Member

Description

Part of stackabletech/issues#838

The clientAuthenticationMethod field from the OIDC ClientAuthenticationOptions is currently deserialized but never used. This PR passes it through to the generated superset_config.py as token_endpoint_auth_method.

Basically the same as stackabletech/superset-operator#716

Requires an operator-rs release with stackabletech/operator-rs#1178.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant