Skip to content
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
41d0f97
WIP: toBeEmpty function
kdquistanchala Mar 17, 2025
6dfdd21
toBeEmpty tests
kdquistanchala Mar 17, 2025
debfd8a
Fix: use element 'children'
kdquistanchala Mar 17, 2025
496edc5
CR: Move isEmpty to a helper file
kdquistanchala Mar 17, 2025
1f78272
Add isEmpty doc.
kdquistanchala Mar 17, 2025
f305bb4
Update: CR comments
kdquistanchala Mar 18, 2025
aed8344
Move toBeEmptyAssertion to the element assertions
kdquistanchala Mar 20, 2025
22e54c9
Add toBeVisible matcher
kdquistanchala Mar 21, 2025
05a57e9
Add tests for toBeVisible
kdquistanchala Mar 21, 2025
abf480a
Fix: Update JSDocs
kdquistanchala Mar 21, 2025
0c30fee
toContainElement() assertion
kdquistanchala Mar 24, 2025
05ef646
Add tests for toContainElement()
kdquistanchala Mar 24, 2025
fda2999
fix: assertions on tests
kdquistanchala Mar 24, 2025
ee0261b
Add toHaveProp function
kdquistanchala Apr 2, 2025
279a50c
Add tests for toHaveProp
kdquistanchala Apr 2, 2025
15a8bee
feat(native): add toHaveStyle (#152)
ACR1209 Mar 24, 2026
c6dcaf2
feat(core): Error type factories (#147)
JoseLion Apr 3, 2025
05818c9
Remove browser support from README (#149)
asimpletune Apr 3, 2025
ca33007
add asimpletune as a contributor for doc (#150)
allcontributors[bot] Apr 3, 2025
3a1b4ab
feat(native): Add toBeEmptyElement (#142)
kdquistanchala Apr 25, 2025
db13aa4
feat(dom): Add toHaveClass , toHaveAllClasses, and toHaveAnyClass ass…
fonsiher May 5, 2025
3d71c35
feat(native): Add toBeVisible (#145)
kdquistanchala Jul 22, 2025
26cc2f4
chore(deps): bump form-data from 4.0.0 to 4.0.4 (#155)
dependabot[bot] Aug 13, 2025
dabcdd4
chore(deps): bump image-size from 1.1.1 to 1.2.1 (#156)
dependabot[bot] Aug 14, 2025
2deccf8
chore(deps): bump path-to-regexp from 6.2.1 to 6.3.0 (#157)
dependabot[bot] Aug 20, 2025
6e4abc7
add suany0805 as a contributor for review (#159)
allcontributors[bot] Nov 13, 2025
fd98641
feat(all): Upgrade Node.js and drop EoLs support (#161)
JoseLion Dec 24, 2025
0594619
feat(dom): DOM - toHaveFocus (#151)
fonsiher Dec 29, 2025
f90c843
feat(dom): DOM - toHaveStyle (#154)
SbsCruz Dec 30, 2025
e273145
feat(dom): DOM - toHaveSomeStyle (#158)
SbsCruz Dec 30, 2025
1eeb6d9
feat(dom): DOM - toBeEmpty (#162)
SbsCruz Feb 23, 2026
adfc2ee
feat(dom): DOM - toHaveDescription (#163)
JDOM10 Mar 12, 2026
91d3b2d
Chore(dom): DOM - helpers refactor (#165)
SbsCruz Mar 23, 2026
d5e1b64
Add toBeVisible matcher
kdquistanchala Mar 21, 2025
c83a948
Fix: Update JSDocs
kdquistanchala Mar 21, 2025
a88cfd4
refactor: removed comments from helpers and types
SbsCruz Apr 1, 2026
81bbbf5
refactor: helpers files created and imports fixed
SbsCruz Apr 1, 2026
e8d657c
feat(native): Add toBeEmptyElement (#142)
kdquistanchala Apr 25, 2025
7bf62fb
feat(native): Add toBeVisible (#145)
kdquistanchala Jul 22, 2025
d8b36bd
CR: Move isEmpty to a helper file
kdquistanchala Mar 17, 2025
0206acd
Add isEmpty doc.
kdquistanchala Mar 17, 2025
c511241
Update: CR comments
kdquistanchala Mar 18, 2025
22d9080
(CR): Address Code Review comments
kdquistanchala Apr 22, 2025
78c4147
Do not use inner function
lopenchi Jul 14, 2025
fdc0670
feat(native): add toHaveStyle (#152)
ACR1209 Mar 24, 2026
7e6d184
refactor: helpers files created and imports fixed
SbsCruz Apr 1, 2026
e5b69c8
fix: moved isElementContained mehtod to helpers/utils.ts
SbsCruz Apr 1, 2026
383c6df
Merge branch 'feat/native-to-contain-element' into feat/native-to-hav…
SbsCruz Apr 1, 2026
48b35db
Fix: removed unused mehtod
SbsCruz Apr 1, 2026
0418614
Fix: removed unused method and imports on tests file
SbsCruz Apr 1, 2026
fadc1eb
Refactor: removed unused helpers file
SbsCruz Apr 1, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 160 additions & 8 deletions packages/native/src/lib/ElementAssertion.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@ import { Assertion, AssertionError } from "@assertive-ts/core";
import { get } from "dot-prop-immutable";
import { ReactTestInstance } from "react-test-renderer";

import { instanceToString, isEmpty } from "./helpers/helpers";

export class ElementAssertion extends Assertion<ReactTestInstance> {
public constructor(actual: ReactTestInstance) {
super(actual);
}

public override toString = (): string => {
if (this.actual === null) {
return "null";
}

return `<${this.actual.type.toString()} ... />`;
return instanceToString(this.actual);
};

/**
Expand All @@ -32,7 +30,7 @@ export class ElementAssertion extends Assertion<ReactTestInstance> {
});
const invertedError = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} to NOT be disabled.`,
message: `Expected element ${this.toString()} NOT to be disabled.`,
});

return this.execute({
Expand All @@ -43,7 +41,7 @@ export class ElementAssertion extends Assertion<ReactTestInstance> {
}

/**
* Check if the component is enabled.
* Check if the component is enabled and has not been disabled by an ancestor.
*
* @example
* ```
Expand All @@ -58,7 +56,7 @@ export class ElementAssertion extends Assertion<ReactTestInstance> {
});
const invertedError = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} to NOT be enabled.`,
message: `Expected element ${this.toString()} NOT to be enabled.`,
});

return this.execute({
Expand All @@ -68,6 +66,140 @@ export class ElementAssertion extends Assertion<ReactTestInstance> {
});
}

/**
* Check if the element is empty.
*
* @example
* ```
* expect(element).toBeEmpty();
* ```
*
* @returns the assertion instance
*/
public toBeEmpty(): this {
const error = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} to be empty.`,
});
const invertedError = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} NOT to be empty.`,
});

return this.execute({
assertWhen: isEmpty(this.actual.children),
error,
invertedError,
});
}

/**
* Check if the element is visible and has not been hidden by an ancestor.
*
* @example
* ```
* expect(element).toBeVisible();
* ```
*
* @returns the assertion instance
*/
public toBeVisible(): this {
const error = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} to be visible.`,
});
const invertedError = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} NOT to be visible.`,
});

return this.execute({
assertWhen: this.isElementVisible(this.actual) && !this.isAncestorNotVisible(this.actual),
error,
invertedError,
});
}

/**
* Check if an element is contained within another element.
*
* @example
* ```
* expect(parent).toContainElement(child);
* ```
*
* @param element - The element to check for.
* @returns the assertion instance
*/
public toContainElement(element: ReactTestInstance): this {
const error = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} to contain element ${instanceToString(element)}.`,
});
const invertedError = new AssertionError({
actual: this.actual,
message: `Expected element ${this.toString()} NOT to contain element ${instanceToString(element)}.`,
});

const isElementContained = (
parentElement: ReactTestInstance,
childElement: ReactTestInstance,
): boolean => {
if (parentElement === null || childElement === null) {
return false;
}

return (
parentElement.findAll(
node =>
node.type === childElement.type && node.props === childElement.props,
).length > 0
);
};

return this.execute({
assertWhen: isElementContained(this.actual, element),
error,
invertedError,
});
}

/**
* Check if the element has a specific property or a specific property value.
*
* @example
* ```
* expect(element).toHaveProp("propName");
* expect(element).toHaveProp("propName", "propValue");
* ```
*
* @param propName - The name of the prop to check for.
* @param value - The value of the prop to check for.
* @returns the assertion instance
*/
public toHaveProp(propName: string, value?: unknown): this {
const propValue: unknown = get(this.actual, `props.${propName}`, undefined);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just as for my understanding, why are we using uknown instead of undefined or any in here?

const hasProp = propValue !== undefined;
const isPropEqual = value === undefined || propValue === value;

const errorMessage = value === undefined
? `Expected element ${this.toString()} to have prop '${propName}'.`
: `Expected element ${this.toString()} to have prop '${propName}' with value '${String(value)}'.`;

const invertedErrorMessage = value === undefined
? `Expected element ${this.toString()} NOT to have prop '${propName}'.`
: `Expected element ${this.toString()} NOT to have prop '${propName}' with value '${String(value)}'.`;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding to the error message something like: Verify the element properties?

const error = new AssertionError({ actual: this.actual, message: errorMessage });
const invertedError = new AssertionError({ actual: this.actual, message: invertedErrorMessage });

return this.execute({
assertWhen: hasProp && isPropEqual,
error,
invertedError,
});
}

private isElementDisabled(element: ReactTestInstance): boolean {
const { type } = element;
const elementType = type.toString();
Expand All @@ -87,4 +219,24 @@ export class ElementAssertion extends Assertion<ReactTestInstance> {
const { parent } = element;
return parent !== null && (this.isElementDisabled(element) || this.isAncestorDisabled(parent));
}

private isElementVisible(element: ReactTestInstance): boolean {
const { type } = element;
const elementType = type.toString();
if (elementType === "Modal" && !element?.props?.visible === true) {
return false;
}

return (
get(element, "props.style.display") !== "none"
&& get(element, "props.style.opacity") !== 0
&& get(element, "props.accessibilityElementsHidden") !== true
&& get(element, "props.importantForAccessibility") !== "no-hide-descendants"
);
}

private isAncestorNotVisible(element: ReactTestInstance): boolean {
const { parent } = element;
return parent !== null && (!this.isElementVisible(element) || this.isAncestorNotVisible(parent));
}
}
33 changes: 33 additions & 0 deletions packages/native/src/lib/helpers/helpers.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { ReactTestInstance } from "react-test-renderer";

/**
* Checks if a value is empty.
*
* @param value - The value to check.
* @returns `true` if the value is empty, `false` otherwise.
*/
export function isEmpty(value: unknown): boolean {
if (!value) {
return true;
}

if (Array.isArray(value)) {
return value.length === 0;
}

return false;
}

/**
* Converts a ReactTestInstance to a string representation.
*
* @param instance - The ReactTestInstance to convert.
* @returns A string representation of the instance.
*/
export function instanceToString(instance: ReactTestInstance | null): string {
if (instance === null) {
return "null";
}

return `<${instance.type.toString()} ... />`;
}
Loading