[7.x] Add $unique argument to Asset::move()#14364
Conversation
jasonvarga
left a comment
There was a problem hiding this comment.
First v7 PR! 🎉
I've just brought master up to date with 6.x if you'd like to fix the conflicts and remove the moveUnique method. (or reopen the PR if that's easier for you)
53edf63 to
4b7a508
Compare
That's actually pretty cool 🥳 The PR is now updated! |
jasonvarga
left a comment
There was a problem hiding this comment.
There's a bunch of unnecessary formatting changes. (e.g. added newlines, renaming unrelated test methods with_events->withEvents).
The moveQuietly method also needs the $unique parameter. Technically it works because it forwards arguments but it should be added.
Remove moveUnique() in favor of a $unique parameter on move(), consistent with how rename() already works. Add $unique parameter to moveQuietly() signature for explicit API parity.
4b7a508 to
5c35199
Compare
|
Right, that was my automatic Pint formatting, I'll make sure future PRs don't include this. This is now cleaned up and the $unique parameter is added to moveQuietly(). |
|
Thanks! |
This is a follow-up to #14236, which added
Asset::moveUnique()as a non-breaking addition for 6.x.Since
masterallows breaking changes, this PR removesmoveUnique()and adds a$uniqueparameter directly toAsset::move(), consistent with howAsset::rename()already works: