feat: Project Setup skill#23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a dedicated “project setup” skill and hardens the project_setup/ tooling (icons, splash, rename) so new projects created from this template can be rebranded and validated more reliably.
Changes:
- Introduces
ai/skills/flutter-template-project-setupdocumentation and updates the root README to reference it. - Improves the Dart setup tool with stricter validation, safer temp-file cleanup, and subprocess failure handling.
- Adds/updates platform-specific generated artifacts (web splash markup, iOS/macOS icon asset metadata) and introduces Snap packaging files.
Reviewed changes
Copilot reviewed 27 out of 80 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| web/index.html | Updates web splash HTML/CSS/script output. |
| snap/snapcraft.yaml | Adds Snapcraft definition for Linux packaging. |
| snap/gui/flutter_app.desktop | Adds desktop entry for the snap GUI integration. |
| README.md | Splits first steps into manual vs automated and links the new skill. |
| project_setup/README.md | Updates required icon size + adds validation notes. |
| project_setup/pubspec.yaml | Bumps netglade_analysis for the setup tool package. |
| project_setup/pubspec.lock | Locks netglade_analysis to the new version. |
| project_setup/lib/main.dart | Makes setup menu loop until exit; adjusts comments. |
| project_setup/lib/core/util/util.dart | Makes setup path handling more robust; validates hex colors. |
| project_setup/lib/core/util/process.dart | Adds helper to run required subprocesses and fail fast on errors. |
| project_setup/lib/core/util/files.dart | Refactors recursive file/directory replace helpers. |
| project_setup/lib/core/splash_screen_generator.dart | Adds input validation, required-process execution, and guaranteed cleanup. |
| project_setup/lib/core/entity/setup_platform.dart | Changes platform “all” helper to a const list. |
| project_setup/lib/core/entity/app_icon_variant_model.dart | Simplifies nullable defaults in the model constructor. |
| project_setup/lib/core/app_rename.dart | Adds configuration validation before performing rebranding. |
| project_setup/lib/core/app_icon_generator.dart | Adds input validation, required-process execution, and guaranteed cleanup. |
| project_setup/lib/configuration.dart | Makes configuration constants const and updates SetupPlatform.all usage. |
| project_setup/analysis_options.yaml | Disables avoid_print / avoid_slow_async_io for the setup tool. |
| makefile | Ensures dart pub get runs in project_setup/ before executing the tool. |
| macos/Runner/Assets.xcassets/productionReleaseAppIcon.appiconset/Contents.json | Adds macOS app icon asset metadata generated by tooling. |
| ios/Runner/Info.plist | Formatting-only change to plist contents. |
| ios/Runner/Assets.xcassets/stagingReleaseAppIcon.appiconset/Contents.json | Reorders JSON info fields (formatting). |
| ios/Runner/Assets.xcassets/stagingDebugAppIcon.appiconset/Contents.json | Reorders JSON info fields (formatting). |
| ios/Runner/Assets.xcassets/productionReleaseAppIcon.appiconset/Contents.json | Reorders JSON info fields (formatting). |
| ios/Runner/Assets.xcassets/productionDebugAppIcon.appiconset/Contents.json | Reorders JSON info fields (formatting). |
| ios/Runner/Assets.xcassets/developReleaseAppIcon.appiconset/Contents.json | Reorders JSON info fields (formatting). |
| ios/Runner/Assets.xcassets/developDebugAppIcon.appiconset/Contents.json | Reorders JSON info fields (formatting). |
| ai/skills/flutter-template-project-setup/SKILL.md | Adds the new “project setup” skill instructions and workflow. |
Comments suppressed due to low confidence (1)
project_setup/lib/core/util/files.dart:55
- When
includedFilesis null,_findAndReplaceTextInDirectorycurrently skips every file (it only processes files whenincludedFiles != null). If the intent is “process all files unless an allowlist is provided”, handle theincludedFiles == nullcase by processing every file (while still respectingexcludedDirs). If the intent is “always require an allowlist”, consider makingincludedFilesrequired to avoid surprising no-op calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.