Merged
Conversation
ktoso
reviewed
Mar 25, 2026
| } | ||
| } | ||
|
|
||
| let sourceDir = target.directory.string |
Collaborator
There was a problem hiding this comment.
Hmm I'm remembering this wasn't available everywhere, let's see if co is happy
ktoso
reviewed
Mar 25, 2026
Collaborator
|
Overall looking good, one nitpick and let's get co green |
ktoso
reviewed
Mar 25, 2026
ktoso
reviewed
Mar 25, 2026
ktoso
reviewed
Mar 25, 2026
Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
Contributor
Author
|
When running |
Collaborator
|
swift-format not being stable is quite problematic yes... We'll probably bump the CI to use 6.3 now that it was released and we can use this as baseline for development. Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes various compiler warnings that have surfaced after recent updates.
The goal is to reduce build-time noise and improve the clarity of the logs.