feat: support USB THP devices from trezor-connect-rs#86
Merged
Conversation
Query transport.has_thp() after acquire to correctly set uses_thp for any device that negotiated THP, not just Bluetooth.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ovitrif
approved these changes
Apr 9, 2026
Collaborator
There was a problem hiding this comment.
The work here is on point; it leads to a better understanding on the issue by my 2 AIs, as they both agree this is a good step in the right direction.
Unfortunately, I still have an issue, and I can't really connect via USB yet, but the new error I'm hitting is now "earlier" in the flow, more self-explanatory and isolated much better.
I'm trying to pick up on this work and these insights and work on a fix, but it will be first in a fork of trezor-connect-rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Resolves Trezor Safe 7 via USB error
transport.has_thp()after acquire to correctly setuses_thpfor any device that negotiated THP, not just Bluetooth.New release for testing created here.