Optimize performance + allocator replacement.#43
Merged
Conversation
1. Rewrite CallbackSubscription: Replace Mutex+timeout polling with channel-based unsubscribe signaling and tokio::select!, eliminating per-message Mutex lock/unlock and timer creation overhead. 2. Switch nats_session from tokio::sync::RwLock to std::sync::RwLock: Clone Client synchronously before entering async futures, removing async lock acquisition from the hot path. Also fix flush() which incorrectly used write() instead of read(). 3. Optimize process_message GIL usage: Combine two GIL acquisitions (Message conversion + callback invocation) into a single Python::attach call via new Message::from_nats_message method. Agent-Logs-Url: https://github.com/taskiq-python/natsrpy/sessions/03a654d2-e0e5-4c06-8341-b78656505688 Co-authored-by: s3rius <[email protected]>
s3rius
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 87.78% 87.33% -0.45%
==========================================
Files 30 30
Lines 3013 2993 -20
==========================================
- Hits 2645 2614 -31
- Misses 368 379 +11 ☔ View full report in Codecov by Sentry. |
…se buffers (#44) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: s3rius <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of small changes here and there.