Port channel send/wait helpers to TestEnv #10159
Merged
Merged
Conversation
stephanos
force-pushed
the
stephanos/chn-helpers-env
branch
from
cd3ea9f to
081a6c3
Compare
stephanos
commented
May 1, 2026
| select { | ||
| case ch <- struct{}{}: | ||
| case <-ctx.Done(): | ||
| s.FailNow("context timeout while sending to channel") |
Contributor
Author
There was a problem hiding this comment.
s.FailNow is not safe in parallelsuite as it might refer to a shared test env.
stephanos
changed the title
stephanos
changed the title
spkane31
approved these changes
May 11, 2026
stephanos
force-pushed
the
stephanos/chn-helpers-env
branch
2 times, most recently
from
8b0e1f1 to
44e496c
Compare
stephanos
force-pushed
the
stephanos/chn-helpers-env
branch
from
44e496c to
7426945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Port
WaitForChannelandSendToChannelto TestEnv.Why?
Safer / simpler.