Fix typescript linter errors

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/effects/debugger_effects_test.ts

@@ -401,9 +401,12 @@ describe('Debugger effects', () => {
     }).compileComponents();
 
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
-    dispatchSpy = spyOn(store, 'dispatch').and.callFake((action: Action) => {
-      dispatchedActions.push(action);
-    });
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    dispatchSpy = (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+      (action: Action) => {
+        dispatchedActions.push(action);
+      }
+    );
     store.overrideSelector(getActivePlugin, '');
   });
 
@@ -436,15 +439,15 @@ describe('Debugger effects', () => {
     begin: number,
     end: number,
     alertsResponse: AlertsResponse,
-    alert_type?: string
+    alertType?: string
   ) {
-    if (alert_type === undefined) {
+    if (alertType === undefined) {
       return spyOn(TestBed.inject(Tfdbg2HttpServerDataSource), 'fetchAlerts')
         .withArgs(runId, begin, end)
         .and.returnValue(of(alertsResponse));
     } else {
       return spyOn(TestBed.inject(Tfdbg2HttpServerDataSource), 'fetchAlerts')
-        .withArgs(runId, begin, end, alert_type)
+        .withArgs(runId, begin, end, alertType)
         .and.returnValue(of(alertsResponse));
     }
   }
@@ -1403,7 +1406,7 @@ describe('Debugger effects', () => {
       },
       begin: 0,
       end: 2,
-      alert_type: AlertType.INF_NAN_ALERT,
+      alertType: AlertType.INF_NAN_ALERT,
       per_type_alert_limit: 1000,
       alerts: [alert0, alert1],
     };
@@ -1657,7 +1660,9 @@ describe('Debugger effects', () => {
         .withArgs(runId, fileIndex)
         .and.returnValue(
           of({
+            // tslint:disable-next-line:enforce-name-casing
             host_name: hostName,
+            // tslint:disable-next-line:enforce-name-casing
             file_path: filePath,
             lines,
           })

tensorboard/webapp/alert/alert_action_test.ts

@@ -59,7 +59,8 @@ describe('alert_effects', () => {
 
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });
   });

tensorboard/webapp/alert/views/alert_snackbar_test.ts

@@ -56,7 +56,8 @@ describe('alert snackbar', () => {
     }).compileComponents();
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });
     overlayContainer = TestBed.inject(OverlayContainer);

tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts

@@ -237,7 +237,8 @@ describe('app_routing_effects', () => {
     store.overrideSelector(getRehydratedDeepLinks, []);
     actualActions = [];
 
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualActions.push(action);
     });
 

tensorboard/webapp/app_routing/views/router_link_test.ts

@@ -73,7 +73,8 @@ describe('router_link', () => {
       AppRootProvider
     ) as TestableAppRootProvider;
 
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualDispatches.push(action);
     });
   });

tensorboard/webapp/core/effects/core_effects_test.ts

@@ -111,7 +111,8 @@ describe('core_effects', () => {
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
 
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });
 

tensorboard/webapp/core/views/layout_test.ts

@@ -85,7 +85,8 @@ describe('layout test', () => {
 
     dispatchedActions = [];
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       dispatchedActions.push(action);
     });
     store.overrideSelector(getSideBarWidthInPercent, 10);

tensorboard/webapp/header/dark_mode_toggle_test.ts

@@ -50,7 +50,8 @@ describe('dark mode toggle test', () => {
     store.overrideSelector(getEnableDarkModeOverride, null);
 
     dispatchedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       dispatchedActions.push(action);
     });
 

tensorboard/webapp/hparams/_redux/hparams_effects_test.ts

@@ -65,9 +65,12 @@ describe('hparams effects', () => {
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
 
     actualActions = [];
-    dispatchSpy = spyOn(store, 'dispatch').and.callFake((action: Action) => {
-      actualActions.push(action);
-    });
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    dispatchSpy = (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+      (action: Action) => {
+        actualActions.push(action);
+      }
+    );
 
     effects = TestBed.inject(HparamsEffects);
     dataSource = TestBed.inject(

tensorboard/webapp/metrics/effects/metrics_effects_test.ts

@@ -85,7 +85,8 @@ describe('metrics effects', () => {
     }).compileComponents();
 
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualActions.push(action);
     });
     effects = TestBed.inject(MetricsEffects);

tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/scalar_column_editor_test.ts

@@ -236,9 +236,12 @@ describe('scalar column editor', () => {
     let dispatchedActions: Action[] = [];
     beforeEach(() => {
       dispatchedActions = [];
-      spyOn(store, 'dispatch').and.callFake((action: Action) => {
-        dispatchedActions.push(action);
-      });
+      // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+      (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+        (action: Action) => {
+          dispatchedActions.push(action);
+        }
+      );
     });
 
     it('dispatches dataTableColumnToggled action with singe selection when checkbox is clicked', fakeAsync(() => {
@@ -320,9 +323,12 @@ describe('scalar column editor', () => {
     let dispatchedActions: Action[] = [];
     beforeEach(() => {
       dispatchedActions = [];
-      spyOn(store, 'dispatch').and.callFake((action: Action) => {
-        dispatchedActions.push(action);
-      });
+      // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+      (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+        (action: Action) => {
+          dispatchedActions.push(action);
+        }
+      );
     });
 
     it('dispatches dataTableColumnOrderChanged action with single selection when header is dragged', fakeAsync(() => {
@@ -508,9 +514,12 @@ describe('scalar column editor', () => {
     let dispatchedActions: Action[] = [];
     beforeEach(() => {
       dispatchedActions = [];
-      spyOn(store, 'dispatch').and.callFake((action: Action) => {
-        dispatchedActions.push(action);
-      });
+      // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+      (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+        (action: Action) => {
+          dispatchedActions.push(action);
+        }
+      );
     });
     it('dispatches metricsSlideoutMenuClosed', () => {
       const fixture = createComponent();
@@ -527,9 +536,12 @@ describe('scalar column editor', () => {
     let dispatchedActions: Action[] = [];
     beforeEach(() => {
       dispatchedActions = [];
-      spyOn(store, 'dispatch').and.callFake((action: Action) => {
-        dispatchedActions.push(action);
-      });
+      // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+      (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+        (action: Action) => {
+          dispatchedActions.push(action);
+        }
+      );
     });
     it('dispatches tableEditorTabChanged action when tab is clicked', fakeAsync(() => {
       const fixture = createComponent();

tensorboard/webapp/notification_center/_redux/notification_center_effects_test.ts

@@ -60,7 +60,8 @@ describe('notification center effects', () => {
     }).compileComponents();
 
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualActions.push(action);
     });
     effects = TestBed.inject(NotificationCenterEffects);
@@ -96,7 +97,7 @@ describe('notification center effects', () => {
 
   it('dispatches failed action when notification fetch failed', () => {
     fetchNotificationsSpy.and.returnValue(
-      throwError(new Error('Request failed'))
+      throwError(() => new Error('Request failed'))
     );
     actions$.next(TEST_ONLY.initAction());
 

tensorboard/webapp/notification_center/_views/notification_center_test.ts

@@ -52,7 +52,8 @@ describe('notification center', () => {
     }).compileComponents();
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });
     store.overrideSelector(selectors.getNotifications, []);

tensorboard/webapp/persistent_settings/_redux/persistent_settings_effects_test.ts

@@ -78,9 +78,12 @@ describe('persistent_settings effects test', () => {
     }).compileComponents();
 
     store = TestBed.inject<Store<any>>(Store) as MockStore<any>;
-    dispatchSpy = spyOn(store, 'dispatch').and.callFake((action: Action) => {
-      actualActions.push(action);
-    });
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    dispatchSpy = (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+      (action: Action) => {
+        actualActions.push(action);
+      }
+    );
     effects = TestBed.inject(PersistentSettingsEffects);
     const dataSource = TestBed.inject(PersistentSettingsTestingDataSource);
     getSettingsSpy = spyOn(dataSource, 'getSettings').and.returnValue(of({}));

tensorboard/webapp/runs/effects/runs_effects_test.ts

@@ -91,7 +91,8 @@ describe('runs_effects', () => {
     selectSpy = spyOn(store, 'select').and.callThrough();
 
     actualActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualActions.push(action);
     });
     effects = TestBed.inject(RunsEffects);

tensorboard/webapp/runs/views/runs_table/filterbar_test.ts

@@ -95,9 +95,12 @@ describe('hparam_filterbar', () => {
   function createComponent(): ComponentFixture<TestableComponent> {
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
     actualActions = [];
-    dispatchSpy = spyOn(store, 'dispatch').and.callFake((action: Action) => {
-      actualActions.push(action);
-    });
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    dispatchSpy = (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+      (action: Action) => {
+        actualActions.push(action);
+      }
+    );
 
     const fixture = TestBed.createComponent(TestableComponent);
     return fixture;

tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_test.ts

@@ -100,9 +100,12 @@ describe('regex_edit_dialog', () => {
     });
     store.overrideSelector(getEnableColorByExperiment, true);
     actualActions = [];
-    dispatchSpy = spyOn(store, 'dispatch').and.callFake((action: Action) => {
-      actualActions.push(action);
-    });
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    dispatchSpy = (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+      (action: Action) => {
+        actualActions.push(action);
+      }
+    );
 
     return TestBed.createComponent(RegexEditDialogContainer);
   }

tensorboard/webapp/runs_legacy/views/legacy_runs_selector/legacy_runs_selector_test.ts

@@ -43,7 +43,8 @@ describe('legacy_runs_selector test', () => {
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
 
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });