gcs: add custom_endpoint config option for GCS regional endpoints#258
Open
Retr0-XD wants to merge 1 commit intothanos-io:mainfrom
Open
gcs: add custom_endpoint config option for GCS regional endpoints#258Retr0-XD wants to merge 1 commit intothanos-io:mainfrom
Retr0-XD wants to merge 1 commit intothanos-io:mainfrom
Conversation
Adds a `custom_endpoint` configuration field to the GCS Config struct, allowing users to override the default Google Cloud Storage API endpoint. This is useful for: - Connecting to GCS regional endpoints for data residency compliance (https://cloud.google.com/storage/docs/regional-endpoints) - Connecting to GCS-compatible storage services When set, the endpoint is passed to the GCS client via option.WithEndpoint(). Fixes: thanos-io/thanos#7862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
custom_endpointconfiguration field to the GCSConfigstruct, allowing users to override the default Google Cloud Storage API endpoint.This is useful for:
When set, the endpoint is passed to the GCS client via
option.WithEndpoint().New config field:
Checklist
custom_endpointfield toConfigstruct with YAML tagcustom_endpointoption.WithEndpoint()when the field is non-empty inNewBucketWithConfigCloses thanos-io/thanos#7862