workflows: add zephyr_revision support to Windows builds#10679
Open
tmleman wants to merge 1 commit intothesofproject:mainfrom
Open
workflows: add zephyr_revision support to Windows builds#10679tmleman wants to merge 1 commit intothesofproject:mainfrom
tmleman wants to merge 1 commit intothesofproject:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Zephyr GitHub Actions workflow so Windows builds can use the same selectable Zephyr revision as Linux builds, preventing Linux/Windows artifact comparisons from failing due to mismatched Zephyr versions.
Changes:
- Adds
zephyr_revisionto the Windows build matrix (mirroring the Linux job). - Adds a Windows (PowerShell) “select zephyr revision” step to apply the requested revision prior to building.
- Ensures Windows artifact upload runs with
if: always()to match Linux behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmleman
requested review from
abonislawski,
kv2019i,
serhiy-katsyuba-intel,
softwarecki and
wjablon1
serhiy-katsyuba-intel
approved these changes
Apr 3, 2026
Fixes the zephyr-main scheduled workflow by ensuring Windows builds use the same Zephyr revision as Linux builds when comparing artifacts. Commit 4a74239 extracted zmain builds into a separate scheduled workflow and parameterized the Linux build job to support the zephyr_revision input. However, the Windows build job was not updated, causing it to always build against the manifest version while Linux built against Zephyr main. This caused the compare-linux-win job to fail when comparing binaries built from different Zephyr versions. Changes: - Add zephyr_revision to build-windows matrix (mirrors build-linux) - Add "select zephyr revision" step for Windows (PowerShell variant) - Add zephyr_revision to Windows sparse matrix include section - Add "if: always()" to Windows artifact upload to match Linux Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the zephyr-main scheduled workflow by ensuring Windows builds use the same Zephyr revision as Linux builds when comparing artifacts.
Commit 4a74239 extracted zmain builds into a separate scheduled workflow and parameterized the Linux build job to support the zephyr_revision input. However, the Windows build job was not updated, causing it to always build against the manifest version while Linux built against Zephyr main. This caused the compare-linux-win job to fail when comparing binaries built from different Zephyr versions.
Changes: