Skip to content

fix: normalize underscore max old space flags #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
immanuwell wants to merge 1 commit into from
+14 −1
Closed

fix: normalize underscore max old space flags #3540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-pots-relax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/core": patch
---

Replace underscore-form Node.js max-old-space-size flags when normalizing NODE_OPTIONS.
2 changes: 1 addition & 1 deletion packages/core/src/v3/machines/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function nodeOptionsWithMaxOldSpaceSize(
let options = existingOptions ?? "";

//remove existing max-old-space-size flag
options = options.replace(/--max-old-space-size=\d+/g, "").trim();
options = options.replace(/--max[-_]old[-_]space[-_]size=\d+/g, "").trim();

//get max-old-space-size flag
const flag = maxOldSpaceSizeFlag(machine, overhead);
Expand Down
8 changes: 8 additions & 0 deletions packages/core/src/v3/machines/max-old-space.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ describe("nodeOptionsWithMaxOldSpaceSize", () => {
expect(result).toBe(`--inspect ${expectedFlag}`);
});

it("replaces existing max_old_space_size flag", () => {
const result = nodeOptionsWithMaxOldSpaceSize(
"--max_old_space_size=4096 --inspect",
testMachine
);
expect(result).toBe(`--inspect ${expectedFlag}`);
});

it("handles multiple existing max-old-space-size flags", () => {
const result = nodeOptionsWithMaxOldSpaceSize(
"--max-old-space-size=4096 --inspect --max-old-space-size=8192",
Expand Down