fix(#785): type dump-manifests missing dir errors#3124
Conversation
Automation needs dump-manifests argument failures to classify without scraping prose, so the --manifests-dir missing-value paths now share the missing_flag_value contract and usage hint. Constraint: Scope limited to ROADMAP #785 and existing rusty-claude-cli JSON error contracts. Rejected: Broader dump-manifests parser cleanup | outside the requested ROADMAP #785 packaging scope. Confidence: high Scope-risk: narrow Directive: Keep future dump-manifests argument errors typed and hint-bearing for JSON callers. Tested: cargo test -p rusty-claude-cli --test output_format_contract -- dump_manifests_missing_dir_has_typed_kind_and_hint_785 --nocapture; cargo test -p rusty-claude-cli classify_error_kind_returns_correct_discriminants -- --nocapture; cargo fmt --all -- --check Not-tested: full workspace test suite
|
Properly typing the missing-dir failure as missing_flag_value makes the error surface machine-readable and actionable. The usage hint for both separated and --manifests-dir= empty forms is a nice UX touch. Note: there are merge conflicts to resolve. |
|
Thanks for the narrow fix. This is superseded by current |
Summary
dump-manifests --manifests-dirmissing-value failures asmissing_flag_valuedump-manifestsusage hint for both separated and--manifests-dir=empty formsValidation
cargo test -p rusty-claude-cli --test output_format_contract -- dump_manifests_missing_dir_has_typed_kind_and_hint_785 --nocapturecargo test -p rusty-claude-cli classify_error_kind_returns_correct_discriminants -- --nocapturecargo fmt --all -- --check