Skip to content

fix(#785): type dump-manifests missing dir errors#3124

Closed
Yeachan-Heo wants to merge 1 commit into
mainfrom
fix/roadmap-785-dump-manifests-missing-dir
Closed

fix(#785): type dump-manifests missing dir errors#3124
Yeachan-Heo wants to merge 1 commit into
mainfrom
fix/roadmap-785-dump-manifests-missing-dir

Conversation

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Summary

  • Type dump-manifests --manifests-dir missing-value failures as missing_flag_value
  • Add a dump-manifests usage hint for both separated and --manifests-dir= empty forms
  • Record ROADMAP 合影合影,笑死了 #785 and add regression coverage

Validation

  • cargo test -p rusty-claude-cli --test output_format_contract -- dump_manifests_missing_dir_has_typed_kind_and_hint_785 --nocapture
  • cargo test -p rusty-claude-cli classify_error_kind_returns_correct_discriminants -- --nocapture
  • cargo fmt --all -- --check

Automation needs dump-manifests argument failures to classify without scraping prose, so the --manifests-dir missing-value paths now share the missing_flag_value contract and usage hint.

Constraint: Scope limited to ROADMAP #785 and existing rusty-claude-cli JSON error contracts.
Rejected: Broader dump-manifests parser cleanup | outside the requested ROADMAP #785 packaging scope.
Confidence: high
Scope-risk: narrow
Directive: Keep future dump-manifests argument errors typed and hint-bearing for JSON callers.
Tested: cargo test -p rusty-claude-cli --test output_format_contract -- dump_manifests_missing_dir_has_typed_kind_and_hint_785 --nocapture; cargo test -p rusty-claude-cli classify_error_kind_returns_correct_discriminants -- --nocapture; cargo fmt --all -- --check
Not-tested: full workspace test suite
@1716775457damn
Copy link
Copy Markdown

Properly typing the missing-dir failure as missing_flag_value makes the error surface machine-readable and actionable. The usage hint for both separated and --manifests-dir= empty forms is a nice UX touch. Note: there are merge conflicts to resolve.

@Yeachan-Heo
Copy link
Copy Markdown
Contributor Author

Thanks for the narrow fix. This is superseded by current main: parse_dump_manifests_args already emits missing_flag_value: --manifests-dir requires a path for both --manifests-dir with no following value and --manifests-dir= with an empty value, with a dump-manifests usage hint. Verification: cargo test --manifest-path rust/Cargo.toml -p rusty-claude-cli dump_manifests_missing_dir_has_typed_kind_and_hint_786 -- --nocapture passed. Closing this PR as duplicate/superseded rather than merging an older patch.

@Yeachan-Heo Yeachan-Heo closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants