[codex] Hide flaky worlds indicators#2000
Open
pranaygp wants to merge 1 commit into
Open
Conversation
Contributor
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)vite (1 failed):
🐘 Local Postgres (1 failed)nextjs-turbopack-stable-lazy-discovery-disabled (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
❌ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the “worlds” UI by removing flaky E2E compatibility indicators and PERF-specific highlighting so the overview/dashboard surfaces focus on stable metadata (package, description, ownership, encryption).
Changes:
- Removed “Fully Compatible” (E2E-based) filtering and summary indicators from the worlds overview/grid and legacy dashboard.
- Removed PERF-specific benchmark labeling/highlighting from the benchmark UI surfaces.
- Simplified world cards/detail hero to drop E2E/benchmark status callouts, keeping emphasis on ownership/encryption and primary links.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/components/worlds/WorldTestingPerformance.tsx | Removes PERF benchmark special-casing (icon/highlight) in the benchmarks table. |
| docs/components/worlds/WorldsFilteredGrid.tsx | Drops the E2E-based “compatible” filter and related counts/UI. |
| docs/components/worlds/WorldsDashboard.tsx | Removes E2E/benchmark summary badges; adds type="button" to filter buttons. |
| docs/components/worlds/WorldDetailHero.tsx | Removes E2E/benchmark quick-link indicators from the detail hero sidebar. |
| docs/components/worlds/WorldCardSimple.tsx | Removes the E2E gauge footer from the simplified world card, keeping encryption only. |
| docs/components/worlds/WorldCard.tsx | Removes E2E status/progress UI from the legacy card component. |
| docs/app/[lang]/worlds/page.tsx | Removes the “Perf” label from the provider benchmark preview header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
15
to
26
| interface WorldCardProps { | ||
| id: string; | ||
| world: World; | ||
| } | ||
|
|
||
| const statusConfig = { | ||
| passing: { | ||
| label: 'Passing', | ||
| icon: CheckCircle2, | ||
| variant: 'default' as const, | ||
| className: 'bg-green-500/10 text-green-600 border-green-500/20', | ||
| }, | ||
| partial: { | ||
| label: 'Partial', | ||
| icon: AlertCircle, | ||
| variant: 'secondary' as const, | ||
| className: 'bg-yellow-500/10 text-yellow-600 border-yellow-500/20', | ||
| }, | ||
| failing: { | ||
| label: 'Failing', | ||
| icon: XCircle, | ||
| variant: 'destructive' as const, | ||
| className: 'bg-red-500/10 text-red-600 border-red-500/20', | ||
| }, | ||
| pending: { | ||
| label: 'Pending', | ||
| icon: Clock, | ||
| variant: 'outline' as const, | ||
| className: 'bg-muted text-muted-foreground', | ||
| }, | ||
| }; | ||
|
|
||
| const typeEmoji = { | ||
| official: '', | ||
| community: '', | ||
| }; | ||
|
|
||
| export function WorldCard({ id, world }: WorldCardProps) { | ||
| const e2eStatus = world.e2e?.status || 'pending'; | ||
| const config = statusConfig[e2eStatus]; | ||
| const StatusIcon = config.icon; | ||
|
|
||
| export function WorldCard({ world }: WorldCardProps) { | ||
| const isExternal = world.docs.startsWith('http'); |
karthikscale3
approved these changes
May 15, 2026
Contributor
karthikscale3
left a comment
karthikscale3
left a comment
There was a problem hiding this comment.
The detail page still shows the data - I guess thats intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm changeset status --since=main->no changeset neededpnpm exec biome check docs/components/worlds/WorldsFilteredGrid.tsx docs/components/worlds/WorldCardSimple.tsx docs/components/worlds/WorldDetailHero.tsx docs/components/worlds/WorldTestingPerformance.tsx docs/components/worlds/WorldsDashboard.tsx docs/components/worlds/WorldCard.tsx docs/app/[lang]/worlds/page.tsxgit diff --checkhttp://localhost:3000/worldswith Playwright at desktop and mobile widthsNote: Biome reports existing complexity warnings in
WorldTestingPerformance.tsx, but exits successfully.