fix(core)!: respect vite https config only for embedded client#273
Open
webfansplz wants to merge 1 commit intomainfrom
Open
fix(core)!: respect vite https config only for embedded client#273webfansplz wants to merge 1 commit intomainfrom
webfansplz wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WebSocket server configuration to allow selectively inheriting Vite’s server.https only when running as an embedded client (and explicitly disabling it for standalone/CLI usage), closing #272.
Changes:
- Replaces
hostWebSocket/portWebSocketwith a structuredwebsocketoptions object (including anhttpsoverride). - Introduces
resolveWebSocketHttps()to implement “inherit unless explicitly disabled” behavior. - Updates server/plugin/CLI integration points to pass the new
websocketoptions and disable HTTPS inheritance where appropriate.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/node/ws.ts | Introduces new websocket options shape and HTTPS resolution logic. |
| packages/core/src/node/plugins/server.ts | Updates embedded server plugin to pass websocket.host (inherits Vite HTTPS). |
| packages/core/src/node/cli-commands.ts | Updates CLI to pass websocket options and explicitly disable HTTPS inheritance. |
| packages/core/src/client/standalone/vite.config.ts | Updates standalone client middleware setup to explicitly disable HTTPS inheritance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
1cfb1a7 to
1960376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #272