fix: improve local bootstrap for contributors#1094
Open
hormers wants to merge 2 commits intovoidzero-dev:mainfrom
Open
fix: improve local bootstrap for contributors#1094hormers wants to merge 2 commits intovoidzero-dev:mainfrom
hormers wants to merge 2 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync-remotereuse GitHub SSH remotes when the local repository is configured for SSH--clone-onlypath sojust initonly bootstraps the pinned upstream source trees needed for local developmentjust initbootstraps pinnedrolldownandvitesourcescurlshim to avoid flaky GitHub release downloads during local setupWhy
Local contributor setup could fail even when GitHub SSH access worked correctly.
Also,
just initwas running logic intended for full upstream dependency sync, which is heavier than the normal contributor bootstrap flow.On macOS, local bootstrap could also fail when transitive build scripts downloaded GitHub release assets through
curland hit transport issues.Scope
This PR includes:
just init/sync-remotewith-curl-http1.tsThe HTTP/1.1
curlshim is only applied on macOS. Other platforms keep their existing behavior.Validation
Validated on macOS with:
just buildpnpm bootstrap-clivp --versionpnpm testI did not validate the bootstrap flow on Windows in this PR.