Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Add snap tests to verify vp build caching works correctly: - vp-build-cache: single package build cache hit - vp-build-cache-monorepo: monorepo with two packages, both hit cache
Remove ignoredPlatforms and ls commands so tests run on all platforms.
Add negative input glob `!node_modules/.vite-temp/**` to Pack and Build subcommands to exclude Vite's transient config files from fspy tracking. Bump vite-task to 8c3cc35e which merges synthetic task input config in the inherited cache path. Closes #1095
fengmk2
changed the title
vite-task now accepts unknown flags as task arguments via trailing_var_arg, so `vp run --yolo` is valid instead of an error.
Test that cache works when first build is from sub dir and second from root, and vice versa. Ensures cache is shared between root and sub workspace invocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputconfig in inherited cache path!node_modules/.vite-temp/**negative input glob to Pack and Build subcommandsVite writes transient compiled config files to
node_modules/.vite-temp/during builds. These files were tracked by fspy as both read and written, causing a read-write overlap that prevented caching ("not cached because it modified its input").The fix has two parts:
inputconfig into parent'sinput_configin theInheritedcache path, resolving globs relative to workspace root!node_modules/.vite-temp/**negative glob viaEnabledCacheConfig.inputon Pack and Build subcommandsSnap tests added
command-pack-monorepovp runcache hit, sub-dir cache hit, source change cache miss, directvp packnot cachedvp-build-cachevp run buildcache hit, directvp buildnot cachedvp-build-cache-monorepovp runcache hit, sub-dir cache hit, source change cache miss, directvp buildnot cachedvp-pack-cache-disabledcache: falsedisables caching forvp packvp-build-cache-disabledcache: falsedisables caching forvp buildTest plan
cargo checkpassescargo testpasses for all vite-plus cratesCloses #1095
🤖 Generated with Claude Code