feat: add jq syntax highlighting#10539
Open
bradleyjames wants to merge 1 commit intowarpdotdev:masterfrom
Open
feat: add jq syntax highlighting#10539bradleyjames wants to merge 1 commit intowarpdotdev:masterfrom
bradleyjames wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
Wires up the existing arborium tree-sitter jq grammar by enabling the lang-jq feature, registering jq in SUPPORTED_LANGUAGES with a `.jq` extension mapping, and adding a config.yaml for indent and bracket metadata. Also keeps the parallel ProgrammingLanguage::to_extension and is_development_text_extension lists in sync.
github-actions
Bot
added
the
external-contributor
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds jq syntax-highlighting support by enabling arborium's jq grammar feature, registering jq in the languages crate, adding the grammar config, and keeping the AI/code-file extension allowlists in sync.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds jq to the list of syntax-highlighted languages by enabling the
lang-jqfeature on arborium and registeringjqincrates/languages/src/lib.rs(SUPPORTED_LANGUAGES, extension mapping, highlight-query lookup). Addscrates/languages/grammars/jq/config.yamlwith display name, 2-space indent,#comment prefix, and standard brackets — uses arborium's bundled highlights, so no.scmfiles are needed. Also keeps the two parallel "kept-in-sync" language lists current:ProgrammingLanguage::to_extensionin the AI agent, andis_development_text_extensioninwarp_util/file_type.rs.Testing
./script/runAutomated coverage:
cargo test -p languages—all_supported_languages_load_successfullyconfirms the grammar + bundled highlight query parse cleanlycargo clippy --workspace --exclude warp_completer --exclude command-signatures-v2 --all-targets --tests -- -D warnings— cleancargo nextest run --workspace --exclude command-signatures-v2— only failures are pre-existing on master (5 SSH integration tests + 1 settings-migration test that depends on absent~/.warp-oss/settings.toml); verified by re-running with my changes stashedScreenshots / Videos
Agent Mode
Used claude code
CHANGELOG-IMPROVEMENT: jq syntax highlighting for code blocks and
.jqfiles