Skip to content

fix: Fix divergent behavior between MemoryStore and LocalStore list_prefix (fixes #3773) #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abishop1990 wants to merge 2 commits into from
Closed

fix: Fix divergent behavior between MemoryStore and LocalStore list_prefix (fixes #3773) #3811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd95d9
fix #3773: Fix divergent behavior between MemoryStore and LocalStore …
Mar 21, 2026
a0e61fe
Merge branch 'main' into issue-3773-store-divergence
abishop1990 Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changes/3773.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Fix divergent behavior between `MemoryStore` and `LocalStore` `list_prefix` methods.

Both stores now consistently use string prefix matching (checking if keys start with the given prefix string),
rather than `LocalStore` treating the prefix as a filesystem directory path. This ensures consistent
behavior across different store implementations and aligns with the documented behavior of `list_prefix`.
9 changes: 6 additions & 3 deletions src/zarr/storage/_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,11 +340,14 @@ async def list(self) -> AsyncIterator[str]:

async def list_prefix(self, prefix: str) -> AsyncIterator[str]:
# docstring inherited
# Use string prefix matching to be consistent with MemoryStore behavior.
# The prefix should match keys as strings, not as filesystem paths.
to_strip = self.root.as_posix() + "/"
prefix = prefix.rstrip("/")
for p in (self.root / prefix).rglob("*"):
for p in list(self.root.rglob("*")):
if p.is_file():
yield p.as_posix().replace(to_strip, "")
key = p.as_posix().replace(to_strip, "")
if key.startswith(prefix):
yield key

async def list_dir(self, prefix: str) -> AsyncIterator[str]:
# docstring inherited
Expand Down
Loading