fix: iac-security-filter flag ignoring passed parameters (AST-145741)#1471
Open
cx-goncalo-lemos wants to merge 2 commits intoCheckmarx:mainfrom
Open
fix: iac-security-filter flag ignoring passed parameters (AST-145741)#1471cx-goncalo-lemos wants to merge 2 commits intoCheckmarx:mainfrom
cx-goncalo-lemos wants to merge 2 commits intoCheckmarx:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
Flag --iac-security-filter (and its deprecated alias --kics-filter) was registered as a String flag in internal/commands/scan.go, but deprecatedFlagValue() reads it using GetStringSlice. This silently returns an empty slice, causing the filter value to be dropped and never sent to the API. As a result, the filter had no effect and files that should have been excluded were still scanned.
Fixed by registering both flags as StringSlice, consistent with how --iac-security-platforms / --kics-platforms are registered.
Type of Change
Related Issues
Link any related issues or tickets.
https://checkmarx.atlassian.net/browse/AST-144685
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.