Skip to content

fix: iac-security-filter flag ignoring passed parameters (AST-145741) #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-goncalo-lemos wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: iac-security-filter flag ignoring passed parameters (AST-145741) #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f1bc33
fix: iac-security-filter flag ignoring passed parameters
cx-goncalo-lemos Apr 9, 2026
54819e6
test: added unit test to check --iac-security-filter value was propag…
cx-goncalo-lemos Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/commands/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,8 +788,8 @@ func scanCreateSubCommand(
commonParams.Branch, commonParams.BranchFlagUsage,
)
createScanCmd.PersistentFlags().String(commonParams.SastFilterFlag, "", commonParams.SastFilterUsage)
createScanCmd.PersistentFlags().String(commonParams.IacsFilterFlag, "", commonParams.IacsFilterUsage)
createScanCmd.PersistentFlags().String(commonParams.KicsFilterFlag, "", commonParams.KicsFilterUsage)
createScanCmd.PersistentFlags().StringSlice(commonParams.IacsFilterFlag, []string{}, commonParams.IacsFilterUsage)
createScanCmd.PersistentFlags().StringSlice(commonParams.KicsFilterFlag, []string{}, commonParams.KicsFilterUsage)

err = createScanCmd.PersistentFlags().MarkDeprecated(commonParams.KicsFilterFlag, "please use the replacement flag --iac-security-filter")
if err != nil {
Expand Down
49 changes: 49 additions & 0 deletions internal/commands/scan_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,6 +1198,55 @@ func TestAddKicsScan(t *testing.T) {
}
}

func TestAddKicsScanWithIacsFilter(t *testing.T) {
var resubmitConfig []wrappers.Config

cmdCommand := &cobra.Command{
Use: "scan",
Short: "Scan a project",
Long: `Scan a project`,
}

cmdCommand.PersistentFlags().StringSlice(
commonParams.KicsFilterFlag,
[]string{},
"Filter for KICS scan",
)

cmdCommand.PersistentFlags().StringSlice(
commonParams.IacsFilterFlag,
[]string{},
"IaC filter",
)

cmdCommand.PersistentFlags().StringSlice(
commonParams.IacsPlatformsFlag,
[]string{},
"IaC platforms",
)

_ = cmdCommand.Execute()

// Set the new --iac-security-filter flag (not the deprecated --kics-filter)
_ = cmdCommand.Flags().Set(commonParams.IacsFilterFlag, "!docker-compose.yaml")

result := addKicsScan(cmdCommand, resubmitConfig)

expectedConfig := wrappers.KicsConfig{
Filter: "!docker-compose.yaml",
}

if result[resultsMapType] != commonParams.KicsType {
t.Errorf("Expected type %s, got %v", commonParams.KicsType, result[resultsMapType])
}

actualConfig := result[resultsMapValue].(*wrappers.KicsConfig)

if !reflect.DeepEqual(actualConfig, &expectedConfig) {
t.Errorf("--iac-security-filter value was not propagated to scan config: expected %+v, got %+v", expectedConfig, actualConfig)
}
}

func TestCreateScanProjectTagsCheckResendToScan(t *testing.T) {
baseArgs := []string{"scan", "create", "--project-name", "sastFilterMock", "-b", "dummy_branch", "-s", dummyRepo, "--project-tags", "SEG", "--debug"}
cmd := createASTTestCommand()
Expand Down