Add test to compare ids from Entity and EntityRep#905
Draft
aritorto wants to merge 3 commits intoOPM:masterfrom
Draft
Add test to compare ids from Entity and EntityRep#905aritorto wants to merge 3 commits intoOPM:masterfrom
aritorto wants to merge 3 commits intoOPM:masterfrom
Conversation
aritorto
force-pushed
the
add-test-idLevelZero
branch
from
1ee0060 to
9cc0757
Compare
aritorto
added
the
manual:irrelevant
Member
Author
|
jenkins build this serial please |
This is not finished but might serve as inspiration.
aritorto
force-pushed
the
add-test-idLevelZero
branch
from
9cc0757 to
69089ed
Compare
Member
Author
|
jenkins build this serial please |
SoilRos
reviewed
Nov 13, 2025
| cell_indexset.beginResize(); | ||
| for (int index = 0, end = size(0); index != end ; ++index){ | ||
| cell_indexset.add(global_id_set_->id(Entity<0>(*this, EntityRep<0>(index, true))), | ||
| cell_indexset.add(global_id_set_->idLevelZero(Entity<0>(*this, EntityRep<0>(index, true))), |
Member
There was a problem hiding this comment.
The results that you encounter are may be explained by this line? This is obtaining the lvl 0 entity id whereas the current master picks up the overload for the different levels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We expect the ids of
EntityandEntityRepto only coincide in the level zero grid, for CpGrid with LGRs.In serial execution, this works as intended.
However, tests show that in parallel execution, they also coincide in refined and leaf grids.
Potential reason: global_id_set_ is not populated for each refined level and leaf grid, then the computation is triggered "on the fly" for each element. Precisely, for a LevelGlobalIdSet levelGlobalIdSet, idSet_ is nullptr and then getMapping is used.
Another alternative is implemented in #898.