Skip to content

fix: Fix main compilation failure#21242

Merged
xudong963 merged 1 commit intoapache:mainfrom
2010YOUY01:fix-ci-fail
Mar 30, 2026
Merged

fix: Fix main compilation failure#21242
xudong963 merged 1 commit intoapache:mainfrom
2010YOUY01:fix-ci-fail

Conversation

@2010YOUY01
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

Due to parallel commits' conflict in #21211 and #21160, the CI is failing, this PR fixes the issue.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Mar 30, 2026
@2010YOUY01
Copy link
Copy Markdown
Contributor Author

This PR only fixes the CI partially 🤔

The extended test failure shows up after #21126, and it's caused by other reasons.

@xudong963
Copy link
Copy Markdown
Member

This PR only fixes the CI partially 🤔

The extended test failure shows up after #21126, and it's caused by other reasons.

I think we can merge it first? Then open another PR to fix extended test if it takes longer time

Copy link
Copy Markdown
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to merge this first.

@xudong963 xudong963 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into apache:main with commit 06b4791 Mar 30, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants