Skip to content

Revert "More module refactoring"#606

Merged
selzoc merged 1 commit into
ubuntu-jammyfrom
revert-595-more-module-refactoring
Jun 2, 2026
Merged

Revert "More module refactoring"#606
selzoc merged 1 commit into
ubuntu-jammyfrom
revert-595-more-module-refactoring

Conversation

@selzoc
Copy link
Copy Markdown
Member

@selzoc selzoc commented Jun 2, 2026

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4a15b3aa-e5df-478e-9383-c3cc8b01d306

📥 Commits

Reviewing files that changed from the base of the PR and between 8c0f1dd and beb3de3.

📒 Files selected for processing (2)
  • bosh-stemcell/spec/support/os_image_linux_kernel_modules_shared_examples.rb
  • stemcell_builder/stages/system_kernel_modules/apply.sh
💤 Files with no reviewable changes (2)
  • stemcell_builder/stages/system_kernel_modules/apply.sh
  • bosh-stemcell/spec/support/os_image_linux_kernel_modules_shared_examples.rb

Walkthrough

This PR updates the set of kernel modules that are blacklisted (prevented from loading) in Linux stemcells. The apply.sh script replaces three module blacklist entries—esp4, esp6, and rxrpc—with three new ones: rds, floppy, and algif_aead. Corresponding test assertions in the shared examples file are removed to reflect the updated blacklist configuration.

Suggested reviewers

  • rkoster
  • beyhan
  • aramprice
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly identifies that this is a revert of a previous change (PR #595), which directly corresponds to the changeset that removes three kernel module blacklist checks and updates module prevention directives.
Description check ✅ Passed The description identifies the reverted PR and references the security notice justifying the revert, but lacks detail about what changes are being reverted and why the revert is necessary beyond the USN reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-595-more-module-refactoring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@selzoc selzoc merged commit 3164d63 into ubuntu-jammy Jun 2, 2026
12 checks passed
@selzoc selzoc deleted the revert-595-more-module-refactoring branch June 2, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants