fix library build for msvc#16131
Draft
NeerajDwivedii wants to merge 2 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request captures kLocation in a lambda within oauth2_regional_access_boundary_token_manager.h and optimizes string concatenation in rest_opentelemetry.cc by replacing standard string addition with absl::StrCat. There are no review comments, and I have no feedback to provide.
NeerajDwivedii
force-pushed
the
fix_msvc_build
branch
3 times, most recently
from
68561e8 to
d72c57a
Compare
NeerajDwivedii
force-pushed
the
fix_msvc_build
branch
from
d72c57a to
d43fe53
Compare
Contributor
|
Lets pic this commit on a test PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation issues when building with the
MSVC compileron Windows.SignUsingSha256function defined in/internal/win32/sign_using_sha256.cc. This issue has now been fixed.error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'std::string'errors were occurring in several lambda functions. These have been fixed.rest_opentelemetry.ccthat was causing compilation failures has also been fixed.