Skip to content

fix library build for msvc #16131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NeerajDwivedii wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Draft

fix library build for msvc #16131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d43fe53
fix: Fixed client library build issue for msvc compiler
NeerajDwivedii Jun 2, 2026
b5a4cee
Merge branch 'main' into fix_msvc_build
NeerajDwivedii Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion google/cloud/internal/oauth2_regional_access_boundary_token_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ class RegionalAccessBoundaryTokenManager
stub = iam_stub_,
retry_policy = retry_policy_->clone(),
backoff_policy = backoff_policy_->clone(),
options = options_]() mutable {
options = options_,
kLocation = kLocation]() mutable {
auto refresh_attempt_fn = [stub](rest_internal::RestContext&,
Options const&, Request const& request) {
return stub->AllowedLocations(request);
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/internal/rest_opentelemetry.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span> MakeSpanHttp(
{/*sc::kUrlFull=*/"url.full", request.path()}},
options);
for (auto const& kv : request.headers()) {
auto const name = "http.request.header." + std::string{kv.first};
auto const name = std::string("http.request.header.") + kv.first.name();
if (kv.second.EmptyValues()) {
span->SetAttribute(name, "");
continue;
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/internal/tracing_rest_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ StatusOr<std::unique_ptr<RestResponse>> EndResponseSpan(
*context.local_port());
}
for (auto const& kv : context.headers()) {
auto const name = "http.request.header." + std::string{kv.first};
auto const name = std::string("http.request.header.") + kv.first.name();
if (kv.second.EmptyValues()) {
span->SetAttribute(name, "");
continue;
Expand Down
3 changes: 2 additions & 1 deletion google/cloud/internal/win32/sign_using_sha256.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ StatusOr<std::vector<std::uint8_t>> SignSha256Digest(BCRYPT_KEY_HANDLE key,
} // namespace

StatusOr<std::vector<std::uint8_t>> SignUsingSha256(
std::string const& str, std::string const& pem_contents) {
std::string const& str, std::string const& pem_contents,
SignatureFormat format) {
auto pem_buffer = DecodePem(pem_contents);
if (!pem_buffer) return std::move(pem_buffer).status();

Expand Down
Loading