Avoid printing stdout/stderr properties in console#7600
Open
Youssef1313 wants to merge 4 commits intomainfrom
Open
Avoid printing stdout/stderr properties in console#7600Youssef1313 wants to merge 4 commits intomainfrom
Youssef1313 wants to merge 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns Microsoft.Testing.Platform’s terminal reporting with VSTest behavior by stopping the console/terminal reporter from rendering per-test captured stdout/stderr, and removing the now-unused localized resource entries.
Changes:
- Remove printing of
StandardOutputProperty/StandardErrorPropertyin terminal test completion output. - Remove
StandardOutput/StandardErrorstring resources fromPlatformResources.resxand all.xlftranslations. - Update terminal reporting call chain to no longer flow stdout/stderr into
TerminalTestReporter.TestCompleted.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf | Removes translated StandardOutput/StandardError entries. |
| src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx | Removes the StandardOutput/StandardError resource keys from the source resx. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs | Stops extracting stdout/stderr properties and stops passing them to terminal reporting. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs | Removes stdout/stderr parameters and removes rendering of those sections from terminal output. |
Comment on lines
326
to
336
| internal void TestCompleted( | ||
| string testNodeUid, | ||
| string displayName, | ||
| TestOutcome outcome, | ||
| TimeSpan? duration, | ||
| string? informativeMessage, | ||
| string? errorMessage, | ||
| Exception? exception, | ||
| string? expected, | ||
| string? actual, | ||
| string? standardOutput, | ||
| string? errorOutput) | ||
| string? actual) | ||
| { |
There was a problem hiding this comment.
TerminalTestReporter.TestCompleted no longer accepts standardOutput/errorOutput, but there are existing internal call sites in unit tests (e.g., TerminalTestReporterTests) still passing those arguments and asserting on the corresponding console output. This will break compilation and/or fail tests; update the tests and expected output to reflect that stdout/stderr are no longer rendered.
Member
Author
|
@copilot Run |
Contributor
|
@Youssef1313 I've opened a new pull request, #7601, to work on those changes. Once the pull request is ready, I'll request review from you. |
…err removal (#7601) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @dgkanatsios