Skip to content

Avoid printing stdout/stderr properties in console #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Youssef1313 merged 4 commits into from
Mar 26, 2026
Merged

Avoid printing stdout/stderr properties in console #7600

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b48bbc
Avoid printing stdout/stderr properties in console
Youssef1313 Mar 24, 2026
64a1e14
Update TerminalTestReporterTests.cs
Youssef1313 Mar 24, 2026
bfd1562
Fix test expectations for terminal output formatting after stdout/std…
Copilot Mar 24, 2026
a1c686e
Delete irrelevant test
Youssef1313 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 5 additions & 35 deletions src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,9 +332,7 @@ internal void TestCompleted(
string? errorMessage,
Exception? exception,
string? expected,
string? actual,
string? standardOutput,
string? errorOutput)
string? actual)
{
Comment thread
Youssef1313 marked this conversation as resolved.
FlatException[] flatExceptions = ExceptionFlattener.Flatten(errorMessage, exception);
TestCompleted(
Expand All @@ -345,9 +343,7 @@ internal void TestCompleted(
informativeMessage,
flatExceptions,
expected,
actual,
standardOutput,
errorOutput);
actual);
}

private void TestCompleted(
Expand All @@ -358,9 +354,7 @@ private void TestCompleted(
string? informativeMessage,
FlatException[] exceptions,
string? expected,
string? actual,
string? standardOutput,
string? errorOutput)
string? actual)
{
if (_testProgressState is null)
{
Expand Down Expand Up @@ -404,9 +398,7 @@ private void TestCompleted(
informativeMessage,
exceptions,
expected,
actual,
standardOutput,
errorOutput));
actual));
}
}

Expand All @@ -424,9 +416,7 @@ private void RenderTestCompleted(
string? informativeMessage,
FlatException[] flatExceptions,
string? expected,
string? actual,
string? standardOutput,
string? errorOutput)
string? actual)
{
if (outcome == TestOutcome.Passed && !GetShowPassedTests())
{
Expand Down Expand Up @@ -468,7 +458,6 @@ private void RenderTestCompleted(
FormatExpectedAndActual(terminal, expected, actual);
FormatStackTrace(terminal, flatExceptions, 0);
FormatInnerExceptions(terminal, flatExceptions);
FormatStandardAndErrorOutput(terminal, standardOutput, errorOutput);
}
Comment thread
Youssef1313 marked this conversation as resolved.

private static void FormatInnerExceptions(ITerminal terminal, FlatException[] exceptions)
Expand Down Expand Up @@ -556,25 +545,6 @@ private static void FormatStackTrace(ITerminal terminal, FlatException[] excepti
terminal.ResetColor();
}

private static void FormatStandardAndErrorOutput(ITerminal terminal, string? standardOutput, string? standardError)
{
if (RoslynString.IsNullOrWhiteSpace(standardOutput) && RoslynString.IsNullOrWhiteSpace(standardError))
{
return;
}

terminal.SetColor(TerminalColor.DarkGray);
terminal.Append(SingleIndentation);
terminal.AppendLine(PlatformResources.StandardOutput);
string? standardOutputWithoutSpecialChars = MakeControlCharactersVisible(standardOutput, normalizeWhitespaceCharacters: false);
AppendIndentedLine(terminal, standardOutputWithoutSpecialChars, DoubleIndentation);
terminal.Append(SingleIndentation);
terminal.AppendLine(PlatformResources.StandardError);
string? standardErrorWithoutSpecialChars = MakeControlCharactersVisible(standardError, normalizeWhitespaceCharacters: false);
AppendIndentedLine(terminal, standardErrorWithoutSpecialChars, DoubleIndentation);
terminal.ResetColor();
}

private void AppendAssemblyLinkTargetFrameworkAndArchitecture(ITerminal terminal)
{
terminal.AppendLink(_assembly, lineNumber: null);
Expand Down
26 changes: 6 additions & 20 deletions src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,6 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
case TestNodeUpdateMessage testNodeStateChanged:

TimeSpan? duration = testNodeStateChanged.TestNode.Properties.SingleOrDefault<TimingProperty>()?.GlobalTiming.Duration;
string? standardOutput = testNodeStateChanged.TestNode.Properties.SingleOrDefault<StandardOutputProperty>()?.StandardOutput;
string? standardError = testNodeStateChanged.TestNode.Properties.SingleOrDefault<StandardErrorProperty>()?.StandardError;

foreach (FileArtifactProperty artifact in testNodeStateChanged.TestNode.Properties.OfType<FileArtifactProperty>())
{
Expand Down Expand Up @@ -420,9 +418,7 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
errorState.Explanation,
errorState.Exception,
expected: null,
actual: null,
standardOutput,
standardError);
actual: null);
break;

case FailedTestNodeStateProperty failedState:
Expand All @@ -435,9 +431,7 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
failedState.Explanation,
failedState.Exception,
expected: failedState.Exception?.Data["assert.expected"] as string,
actual: failedState.Exception?.Data["assert.actual"] as string,
standardOutput,
standardError);
actual: failedState.Exception?.Data["assert.actual"] as string);
break;

case TimeoutTestNodeStateProperty timeoutState:
Expand All @@ -450,9 +444,7 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
timeoutState.Explanation,
timeoutState.Exception,
expected: null,
actual: null,
standardOutput,
standardError);
actual: null);
break;

#pragma warning disable CS0618 // Type or member is obsolete
Expand All @@ -467,9 +459,7 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
cancelledState.Explanation,
cancelledState.Exception,
expected: null,
actual: null,
standardOutput,
standardError);
actual: null);
break;

case PassedTestNodeStateProperty:
Expand All @@ -482,9 +472,7 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
errorMessage: null,
exception: null,
expected: null,
actual: null,
standardOutput,
standardError);
actual: null);
break;

case SkippedTestNodeStateProperty skippedState:
Expand All @@ -497,9 +485,7 @@ public Task ConsumeAsync(IDataProducer dataProducer, IData value, CancellationTo
errorMessage: null,
exception: null,
expected: null,
actual: null,
standardOutput,
standardError);
actual: null);
break;

case DiscoveredTestNodeStateProperty:
Expand Down
6 changes: 0 additions & 6 deletions src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,12 +625,6 @@ Takes one argument as string in the format &lt;value&gt;[h|m|s] where 'value' is
<data name="MissingClientPortFoJsonRpc" xml:space="preserve">
<value>Expected --client-port when jsonRpc protocol is used.</value>
</data>
<data name="StandardError" xml:space="preserve">
<value>Error output</value>
</data>
<data name="StandardOutput" xml:space="preserve">
<value>Standard output</value>
</data>
<data name="DiscoveringTestsFrom" xml:space="preserve">
<value>Discovering tests from</value>
</data>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Může mít jenom jeden argument jako řetězec ve formátu &lt;value&gt;[h|m|s]
<target state="translated">Trasování zásobníku</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Chybový výstup</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Standardní výstup</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Spouští se testovací relace.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Nimmt ein Argument als Zeichenfolge im Format &lt;value&gt;[h|m|s], wobei "value
<target state="translated">Stapelüberwachung</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Fehlerausgabe</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Standardausgabe</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Die Testsitzung wird gestartet.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Toma un argumento como cadena con el formato &lt;value&gt;[h|m|s] donde 'value'
<target state="translated">Seguimiento de la pila</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Salida de error</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Salida estándar</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Iniciando sesión de prueba.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Prend un argument sous forme de chaîne au format &lt;value&gt;[h|m|s] où « v
<target state="translated">Rapport des appels de procédure</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Sortie d’erreur</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Sortie standard</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Démarrage de la session de test.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Acquisisce un argomento come stringa nel formato &lt;value&gt;[h|m|s] dove 'valu
<target state="translated">Analisi dello stack</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Output errori</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Output standard</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Avvio della sessione di test.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,16 +744,6 @@ Takes one argument as string in the format &lt;value&gt;[h|m|s] where 'value' is
<target state="translated">スタック トレース</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">エラー出力</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">標準出力</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">テスト セッションを開始しています。</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Takes one argument as string in the format &lt;value&gt;[h|m|s] where 'value' is
<target state="translated">스택 추적</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">오류 출력</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">표준 출력</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">테스트 세션을 시작하는 중입니다.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Pobiera jeden argument jako ciąg w formacie &lt;value&gt;[h|m|s], gdzie element
<target state="translated">Śledzenie stosu</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Dane wyjściowe w przypadku błędu</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Standardowe dane wyjściowe</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Rozpoczynanie sesji testowej.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Recebe um argumento como cadeia de caracteres no formato &lt;valor&gt;[h|m|s] em
<target state="translated">Rastreamento de Pilha</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Saída de erros</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Saída padrão</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Iniciando sessão de teste.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Takes one argument as string in the format &lt;value&gt;[h|m|s] where 'value' is
<target state="translated">Трассировка стека</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Вывод ошибок</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Стандартный вывод</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Запуск тестового сеанса.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Bir bağımsız değişkeni, 'value' değerinin kayan olduğu &lt;value&gt;[h|m|
<target state="translated">Yığın İzlemesi</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">Hata çıkışı</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">Standart çıkış</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">Test oturumu başlatılıyor.</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Takes one argument as string in the format &lt;value&gt;[h|m|s] where 'value' is
<target state="translated">堆栈跟踪</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">错误输出</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">标准输出</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">正在启动测试会话。</target>
Expand Down
10 changes: 0 additions & 10 deletions src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,16 +743,6 @@ Takes one argument as string in the format &lt;value&gt;[h|m|s] where 'value' is
<target state="translated">堆疊追蹤</target>
<note />
</trans-unit>
<trans-unit id="StandardError">
<source>Error output</source>
<target state="translated">錯誤輸出</target>
<note />
</trans-unit>
<trans-unit id="StandardOutput">
<source>Standard output</source>
<target state="translated">標準輸出</target>
<note />
</trans-unit>
<trans-unit id="StartingTestSession">
<source>Starting test session.</source>
<target state="translated">正在啟動測試會話。</target>
Expand Down
Loading
Loading