[devscripts] fix quoted version test conditional#3800
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Mar 27, 2026
Conversation
Contributor
Author
|
My deployment fails without this patch when I use the following ansible: |
The when condition in 137_custom_install.yml wrapped the version test expression in double quotes, causing Ansible to evaluate it as a non-empty string (always True) instead of a boolean. Remove the outer quotes so the expression is evaluated correctly. Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: John Fulton <fulton@redhat.com>
0d73265 to
72f4621
Compare
evallesp
approved these changes
Mar 26, 2026
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amartyasinha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0476f9d
into
openstack-k8s-operators:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The when condition in 137_custom_install.yml wrapped the version test expression in double quotes, causing Ansible to evaluate it as a non-empty string (always True) instead of a boolean. Remove the outer quotes so the expression is evaluated correctly.
Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com