Skip to content

[devscripts] fix quoted version test conditional#3800

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
fultonj:fix/devscripts-quoted-version-conditional
Mar 27, 2026
Merged

[devscripts] fix quoted version test conditional#3800
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
fultonj:fix/devscripts-quoted-version-conditional

Conversation

@fultonj
Copy link
Copy Markdown
Contributor

@fultonj fultonj commented Mar 25, 2026

The when condition in 137_custom_install.yml wrapped the version test expression in double quotes, causing Ansible to evaluate it as a non-empty string (always True) instead of a boolean. Remove the outer quotes so the expression is evaluated correctly.

Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com

@fultonj
Copy link
Copy Markdown
Contributor Author

fultonj commented Mar 25, 2026

My deployment fails without this patch when I use the following ansible:

$ ansible --version
ansible [core 2.20.3]
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/johfulto/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/johfulto/test-python/lib64/python3.14/site-packages/ansible
  ansible collection location = /home/johfulto/.ansible/collections:/usr/share/ansible/collections
  executable location = /home/johfulto/test-python/bin/ansible
  python version = 3.14.3 (main, Feb  4 2026, 00:00:00) [GCC 15.2.1 20260123 (Red Hat 15.2.1-7)] (/home/johfulto/test-python/bin/python3)
  jinja version = 3.1.6
  pyyaml version = 6.0.3 (with libyaml v0.2.5)

The when condition in 137_custom_install.yml wrapped the version
test expression in double quotes, causing Ansible to evaluate it
as a non-empty string (always True) instead of a boolean.
Remove the outer quotes so the expression is evaluated correctly.

Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: John Fulton <fulton@redhat.com>
@evallesp
Copy link
Copy Markdown
Contributor

/lgtm

Copy link
Copy Markdown
Contributor

@amartyasinha amartyasinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amartyasinha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0476f9d into openstack-k8s-operators:main Mar 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants