Warn when two executables have the same revision and flags#503
Open
Warn when two executables have the same revision and flags#503
Conversation
When benchmarking two rubies that produce identical `ruby -v` output and use the same command-line flags, it's likely a user mistake. Skip the warning when JIT flags differ, since comparing JIT vs non-JIT on the same revision is a valid use case.
XrXr
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prints a warning when you pass multiple binaries through
--chrubyor-ethat are identical Ruby and flags.When benchmarking two rubies that produce identical
ruby -voutput and use the same command-line flags, it's likely a user mistake. Skip the warning when JIT flags differ, since comparing JIT vs non-JIT on the same revision is a valid use case.