Skip to content

Warn when two executables have the same revision and flags #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k0kubun wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

Warn when two executables have the same revision and flags #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/benchmark_runner/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@

module BenchmarkRunner
class CLI
BOLD = "\e[1m"
RESET = "\e[0m"

attr_reader :args

def self.run(argv = ARGV)
Expand Down Expand Up @@ -45,6 +48,18 @@ def run
ruby_descriptions[name] = `#{executable.shelljoin} -v`.chomp
end

# Warn if two executables look identical (same ruby -v output and same flags)
names = ruby_descriptions.keys
names.each_with_index do |name_a, i|
names[(i + 1)..].each do |name_b|
flags_a = args.executables[name_a][1..] || []
flags_b = args.executables[name_b][1..] || []
if ruby_descriptions[name_a] == ruby_descriptions[name_b] && flags_a == flags_b
warn "#{BOLD}WARNING: '#{name_a}' and '#{name_b}' appear identical (same revision, same flags). This is likely a mistake.#{RESET}"
end
end
end

bench_start_time = Time.now.to_f
bench_data = {}
bench_failures = {}
Expand Down
Loading