fix: wants vs has#1017
Merged
mdydek merged 2 commits intofix/1004-invalid-engine-state-on-recording-or-playback-startfrom Apr 14, 2026
Merged
Conversation
mdydek
force-pushed
the
fix/1004-invalid-engine-state-on-recording-or-playback-start-locks
branch
from
8dcbdd7 to
aea7df4
Compare
mdydek
merged commit 5516121
into
fix/1004-invalid-engine-state-on-recording-or-playback-start
4 of 6 checks passed
maciejmakowski2003
added a commit
that referenced
this pull request
Apr 14, 2026
* fix: sloppified fix for engine/session management * fix: format with valid clang-format version * fix: cleanup hallucination v1 * fix: recorder host object missing function definition * fix: invalid engine state after session deactivation * fix: cleanup unnecessary code * fix: cleanup unnecessary code * feat: ios engine test coverage + small cleanups * feat: works * fix: re-create engine together with nodes * fix: remove tmp files, better recorder start error flow * fix: cleanup tests * fix: cleanup stress tests slop * chore: cleanup * ci: format * fix: ios recorder tests * fix: wants vs has (#1017) * fix: removed unnecesary screen * test: recorder restarts an engine * refactor: removed old todos and use resolved buffer size * fix: removed batchDurationSeconds --------- Co-authored-by: michal <dydmichal@gmail.com> Co-authored-by: maciejmakowski2003 <maciejmakowski2003@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist